From: Maria Matejka <mq@ucw.cz>
Date: Wed, 16 Jul 2025 08:45:10 +0000 (+0200)
Subject: BGP: Fixed link-local connections with wildcard local iface
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=863bc02029690b45b2ef8a27837c905cb66ea7d3;p=thirdparty%2Fbird.git

BGP: Fixed link-local connections with wildcard local iface

When BGP was configured to accept link-local connections
in combination with interface range, it failed to recognize
that the incoming connection is indeed for that protocol.
---

diff --git a/proto/bgp/bgp.c b/proto/bgp/bgp.c
index fb6410ab0..fea51781c 100644
--- a/proto/bgp/bgp.c
+++ b/proto/bgp/bgp.c
@@ -1737,7 +1737,7 @@ bgp_find_proto(sock *sk)
 	(!p->cf->remote_range || ipa_in_netX(sk->daddr, p->cf->remote_range)) &&
 	(p->p.vrf == sk->vrf) &&
 	(p->cf->local_port == sk->sport) &&
-	(!link || (p->cf->iface == sk->iface)) &&
+	(!link || (p->cf->iface == sk->iface) || p->cf->ipatt && sk->iface && iface_patt_match(p->cf->ipatt, sk->iface, NULL)) &&
 	(ipa_zero(p->cf->local_ip) || ipa_equal(p->cf->local_ip, sk->saddr)))
     {
       best = p;