From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Mon, 11 Mar 2024 11:39:36 +0000 (+0100)
Subject: simplify return type usage
X-Git-Tag: dnsdist-1.10.0-alpha0~3^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=863fa7f60d889126e8df57e3a62f1a0ef6e7108a;p=thirdparty%2Fpdns.git

simplify return type usage
---

diff --git a/pdns/lua-record.cc b/pdns/lua-record.cc
index ed1839c68d..86c4450bee 100644
--- a/pdns/lua-record.cc
+++ b/pdns/lua-record.cc
@@ -1057,24 +1057,24 @@ static void setupLuaRecords(LuaContext& lua) // NOLINT(readability-function-cogn
       return std::string("unknown");
     });
 
-  lua.writeFunction("filterForward", [](string address, NetmaskGroup& nmg, boost::optional<string> fallback) {
+  lua.writeFunction("filterForward", [](const string& address, NetmaskGroup& nmg, boost::optional<string> fallback) -> vector<string> {
       ComboAddress ca(address);
 
       if (nmg.match(ComboAddress(address))) {
-        return vector<string>{address};
+        return {address};
       } else {
         if (fallback) {
           if (fallback->empty()) {
             // if fallback is an empty string, return an empty array
-            return vector<string>{};
+            return {};
           }
-          return vector<string>{*fallback};
+          return {*fallback};
         }
 
         if (ca.isIPv4()) {
-          return vector<string>{string("0.0.0.0")};
+          return {string("0.0.0.0")};
         } else {
-          return vector<string>{string("::")};
+          return {string("::")};
         }
       }
     });