From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Tue, 1 Feb 2022 15:31:52 +0000 (+0000)
Subject: core: warn on ExitType=cgroup with legacy cgroup setup
X-Git-Tag: v251-rc1~384
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86838bf08be18cf8cd5a7332820623c1853532c0;p=thirdparty%2Fsystemd.git

core: warn on ExitType=cgroup with legacy cgroup setup

'cgroup empty' notifications are not reliable on v1, so log a warning.

See: https://github.com/systemd/systemd/issues/22320
---

diff --git a/src/core/service.c b/src/core/service.c
index 905558af57c..c767a38b290 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -624,6 +624,9 @@ static int service_verify(Service *s) {
         if (s->runtime_max_usec == USEC_INFINITY && s->runtime_rand_extra_usec != 0)
                 log_unit_warning(UNIT(s), "Service has RuntimeRandomizedExtraSec= setting, but no RuntimeMaxSec=. Ignoring.");
 
+        if (s->exit_type == SERVICE_EXIT_CGROUP && cg_unified() < CGROUP_UNIFIED_SYSTEMD)
+                log_unit_warning(UNIT(s), "Service has ExitType=cgroup set, but we are running with legacy cgroups v1, which might not work correctly. Continuing.");
+
         return 0;
 }