From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 1 Aug 2023 13:09:25 +0000 (+0200)
Subject: rec: Prevent a copy in RecursorLua4::DNSQuestion::addAnswer
X-Git-Tag: rec-5.0.0-alpha1~76^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86867a80b19a40644e5d5d1c2dcacccb70695b85;p=thirdparty%2Fpdns.git

rec: Prevent a copy in RecursorLua4::DNSQuestion::addAnswer

Reported by Coverity as 1509322
---

diff --git a/pdns/recursordist/lua-recursor4.cc b/pdns/recursordist/lua-recursor4.cc
index b35cfd0d94..04c538025c 100644
--- a/pdns/recursordist/lua-recursor4.cc
+++ b/pdns/recursordist/lua-recursor4.cc
@@ -140,7 +140,7 @@ void RecursorLua4::DNSQuestion::addRecord(uint16_t type, const std::string& cont
 
 void RecursorLua4::DNSQuestion::addAnswer(uint16_t type, const std::string& content, boost::optional<int> ttl, boost::optional<string> name)
 {
-  addRecord(type, content, DNSResourceRecord::ANSWER, ttl, name);
+  addRecord(type, content, DNSResourceRecord::ANSWER, ttl, std::move(name));
 }
 
 struct DynMetric