From: Timo Sirainen <tss@iki.fi>
Date: Sat, 19 Jun 2004 17:41:30 +0000 (+0300)
Subject: minor fix for error handling
X-Git-Tag: 1.1.alpha1~3936
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86bc22621dcce6d9f1ca7216c9cc958381a61277;p=thirdparty%2Fdovecot%2Fcore.git

minor fix for error handling

--HG--
branch : HEAD
---

diff --git a/src/lib-index/mail-index.c b/src/lib-index/mail-index.c
index acb30e168a..584327129e 100644
--- a/src/lib-index/mail-index.c
+++ b/src/lib-index/mail-index.c
@@ -573,18 +573,17 @@ static int mail_index_create(struct mail_index *index,
 			mail_index_file_set_syscall_error(index, path,
 							  "unlink()");
 		}
-		return -1;
-	}
-
-	/* make it visible to others */
-	if (rename(path, index->filepath) < 0) {
-		mail_index_set_error(index, "rename(%s, %s) failed: %m",
-				     path, index->filepath);
-		return -1;
+	} else {
+		/* make it visible to others */
+		if (rename(path, index->filepath) < 0) {
+			mail_index_set_error(index, "rename(%s, %s) failed: %m",
+					     path, index->filepath);
+			ret = -1;
+		}
 	}
 
 	mail_transaction_log_sync_unlock(index->log);
-	return 1;
+	return ret;
 }
 
 static void mail_index_header_init(struct mail_index *index,