From: ghendricks%novell.com <>
Date: Thu, 5 Feb 2009 18:38:32 +0000 (+0000)
Subject:  Bug 476678 -  Rich clients unable to update bugs need security token included in... 
X-Git-Tag: bugzilla-3.2.3~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86cee2eef218d79bc99bebe9170abf0574564f7c;p=thirdparty%2Fbugzilla.git

 Bug 476678 -  Rich clients unable to update bugs need security token included in bug xml
 patch by ghendricks@novell.com r=LpSolit a=LpSolit
---

diff --git a/importxml.pl b/importxml.pl
index 6b0c043b4d..d24c1ee1c1 100755
--- a/importxml.pl
+++ b/importxml.pl
@@ -474,6 +474,11 @@ sub process_bug {
    # append it to the log, which will go into the comments when we are done.
     foreach my $bugchild ( $bug->children() ) {
         Debug( "Parsing field: " . $bugchild->name, DEBUG_LEVEL );
+
+        # Skip the token if one is included. We don't want it included in
+        # the comments, and it is not used by the importer.
+        next if $bugchild->name eq 'token';
+
         if ( defined $all_fields{ $bugchild->name } ) {
             my @values = $bug->children_text($bugchild->name);
             if (scalar @values > 1) {
diff --git a/show_bug.cgi b/show_bug.cgi
index 59e2286c34..2655e5f33e 100755
--- a/show_bug.cgi
+++ b/show_bug.cgi
@@ -115,7 +115,7 @@ $vars->{'bug_list'} = \@bug_list;
 # on the exclusion list. This is so you can say e.g. "Everything except 
 # attachments" without listing almost all the fields.
 my @fieldlist = (Bugzilla::Bug->fields, 'group', 'long_desc', 
-                 'attachment', 'attachmentdata');
+                 'attachment', 'attachmentdata', 'token');
 my %displayfields;
 
 if ($cgi->param("field")) {
diff --git a/template/en/default/bug/show.xml.tmpl b/template/en/default/bug/show.xml.tmpl
index 23874d989b..bd74592714 100644
--- a/template/en/default/bug/show.xml.tmpl
+++ b/template/en/default/bug/show.xml.tmpl
@@ -44,6 +44,11 @@
         [% END %]
       [% END %]
 
+      [%# This is here so automated clients can still use process_bug.cgi %]
+      [% IF displayfields.token && user.id %]
+          <token>[% issue_hash_token([bug.id, bug.delta_ts]) FILTER xml %]</token>
+      [% END %]
+
       [%# Now handle 'special' fields #%]
       [% IF displayfields.group %]
         [% FOREACH g = bug.groups %]