From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 18 Mar 2022 15:57:56 +0000 (+0100)
Subject: timesyncd: rename bool 'good' → 'talking'
X-Git-Tag: v251-rc1~92^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=87057128e65c6b76c0eaf5f7f7b701831598c473;p=thirdparty%2Fsystemd.git

timesyncd: rename bool 'good' → 'talking'

THe name is just too generic. Let's pick a name that makes clear that
this is about successful communication.
---

diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c
index b491db23bc4..03363640b30 100644
--- a/src/timesync/timesyncd-manager.c
+++ b/src/timesync/timesyncd-manager.c
@@ -593,10 +593,10 @@ static int manager_receive_response(sd_event_source *source, int fd, uint32_t re
                                 "NTPMessage",
                                 NULL);
 
-        if (!m->good) {
+        if (!m->talking) {
                 _cleanup_free_ char *pretty = NULL;
 
-                m->good = true;
+                m->talking = true;
 
                 (void) server_address_pretty(m->current_server_address, &pretty);
 
@@ -659,7 +659,7 @@ static int manager_begin(Manager *m) {
         assert_return(m->current_server_name, -EHOSTUNREACH);
         assert_return(m->current_server_address, -EHOSTUNREACH);
 
-        m->good = false;
+        m->talking = false;
         m->missed_replies = NTP_MAX_MISSED_REPLIES;
         if (m->poll_interval_usec == 0)
                 m->poll_interval_usec = m->poll_interval_min_usec;
diff --git a/src/timesync/timesyncd-manager.h b/src/timesync/timesyncd-manager.h
index 5368dba98c0..6244e075924 100644
--- a/src/timesync/timesyncd-manager.h
+++ b/src/timesync/timesyncd-manager.h
@@ -61,7 +61,7 @@ struct Manager {
         int missed_replies;
         uint64_t packet_count;
         sd_event_source *event_timeout;
-        bool good;
+        bool talking;
 
         /* last sent packet */
         struct timespec trans_time_mon;