From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 25 Jan 2023 01:33:27 +0000 (-0500)
Subject: use FR_TACACS_PACKET_CODE_VALID
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=871d871fb9b9a9cb51ad3e567ec94e0213d9f15d;p=thirdparty%2Ffreeradius-server.git

use FR_TACACS_PACKET_CODE_VALID
---

diff --git a/src/modules/rlm_tacacs/rlm_tacacs.c b/src/modules/rlm_tacacs/rlm_tacacs.c
index d8f219fee9b..98ce226ef11 100644
--- a/src/modules/rlm_tacacs/rlm_tacacs.c
+++ b/src/modules/rlm_tacacs/rlm_tacacs.c
@@ -157,12 +157,7 @@ static unlang_action_t CC_HINT(nonnull) mod_process(rlm_rcode_t *p_result, modul
 
 	void			*rctx = NULL;
 
-	if (!request->packet->code) {
-		REDEBUG("You MUST specify a packet code");
-		RETURN_MODULE_FAIL;
-	}
-
-	if (request->packet->code >= FR_TACACS_PACKET_TYPE_MAX) {
+	if (!FR_TACACS_PACKET_CODE_VALID(request->packet->code)) {
 		REDEBUG("Invalid packet code %d", request->packet->code);
 		RETURN_MODULE_FAIL;
 	}