From: Ray Strode <rstrode@redhat.com>
Date: Wed, 20 Oct 2010 14:04:24 +0000 (-0400)
Subject: boot-server: don't print error when client goes away
X-Git-Tag: 0.8.4~97
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=871dbcbccea74266365e5bac54dd3b1b6eceb84b;p=thirdparty%2Fplymouth.git

boot-server: don't print error when client goes away

Right now, anytime the server is unable to respond to a
client it puts an ugly message on the screen:

"could not write bytes: Broken pipe"

or some such.  That message isn't really useful unless you're
debugging your distribution, so change it from a ply_error to
ply_trace.
---

diff --git a/src/ply-boot-server.c b/src/ply-boot-server.c
index 3fbe8100..3095d940 100644
--- a/src/ply-boot-server.c
+++ b/src/ply-boot-server.c
@@ -271,7 +271,7 @@ ply_boot_connection_send_answer (ply_boot_connection_t *connection,
       if (!ply_write (connection->fd,
                       PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NO_ANSWER,
                       strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NO_ANSWER)))
-        ply_error ("could not write bytes: %m");
+        ply_trace ("could not write bytes: %m");
     }
   else
     {
@@ -284,7 +284,7 @@ ply_boot_connection_send_answer (ply_boot_connection_t *connection,
                              size) ||
           !ply_write (connection->fd,
                       answer, size))
-          ply_error ("could not write bytes: %m");
+          ply_trace ("could not write bytes: %m");
 
     }
 
@@ -311,7 +311,7 @@ ply_boot_connection_on_deactivated (ply_boot_connection_t *connection)
                   PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK,
                   strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK)))
     {
-      ply_error ("could not write bytes: %m");
+      ply_trace ("could not write bytes: %m");
     }
 }
 
@@ -323,7 +323,7 @@ ply_boot_connection_on_quit_complete (ply_boot_connection_t *connection)
                   PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK,
                   strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK)))
     {
-      ply_error ("could not write bytes: %m");
+      ply_trace ("could not write bytes: %m");
     }
 }
 
@@ -390,7 +390,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
       if (!ply_write (connection->fd,
                       PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK,
                       strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK)))
-        ply_error ("could not write bytes: %m");
+        ply_trace ("could not write bytes: %m");
 
       free (command);
       return;
@@ -402,7 +402,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
       if (!ply_write (connection->fd,
                       PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK,
                       strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK)))
-        ply_error ("could not write bytes: %m");
+        ply_trace ("could not write bytes: %m");
 
       ply_trace ("got update request");
       if (server->update_handler != NULL)
@@ -548,7 +548,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
           if (!ply_write (connection->fd,
                           PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NO_ANSWER,
                           strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NO_ANSWER)))
-              ply_error ("could not write bytes: %m");
+              ply_trace ("could not write bytes: %m");
         }
       else
         {
@@ -563,7 +563,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
                                  size) ||
               !ply_write (connection->fd,
                           ply_buffer_get_bytes (buffer), size))
-              ply_error ("could not write bytes: %m");
+              ply_trace ("could not write bytes: %m");
         }
 
       ply_buffer_free (buffer);
@@ -667,7 +667,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
           if (!ply_write (connection->fd,
                           PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK,
                           strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK)))
-            ply_error ("could not write bytes: %m");
+            ply_trace ("could not write bytes: %m");
 
           free(command);
           return;
@@ -680,7 +680,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
       if (!ply_write (connection->fd,
                       PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK,
                       strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_NAK)))
-        ply_error ("could not write bytes: %m");
+        ply_trace ("could not write bytes: %m");
 
       free(command);
       return;
@@ -690,7 +690,7 @@ ply_boot_connection_on_request (ply_boot_connection_t *connection)
                   PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK,
                   strlen (PLY_BOOT_PROTOCOL_RESPONSE_TYPE_ACK)))
     {
-      ply_error ("could not write bytes: %m");
+      ply_trace ("could not write bytes: %m");
     }
   free(command);
 }