From: Karel Zak <kzak@redhat.com>
Date: Mon, 12 Sep 2011 13:33:04 +0000 (+0200)
Subject: libmount: variable dereferenced before check [smatch scan]
X-Git-Tag: v2.21-rc1~420
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8726371fb8e54ca473df3369a6c4692b7588807c;p=thirdparty%2Futil-linux.git

libmount: variable dereferenced before check [smatch scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libmount/src/tab_update.c b/libmount/src/tab_update.c
index 3d2bd00e9e..f049e42c06 100644
--- a/libmount/src/tab_update.c
+++ b/libmount/src/tab_update.c
@@ -718,7 +718,7 @@ int mnt_update_table(struct libmnt_update *upd, struct libmnt_lock *lc)
 
 	assert(upd);
 
-	if (!upd->filename || !upd)
+	if (!upd || !upd->filename)
 		return -EINVAL;
 	if (!upd->ready)
 		return 0;