From: Pavel Filipenský <pfilipensky@samba.org>
Date: Wed, 23 Apr 2025 07:34:14 +0000 (+0200)
Subject: lib/krb5_wrap: Fix placement of TALLOC_FREE(frame)
X-Git-Tag: samba-4.21.6~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8743dd673afaea23683ce5f82a33b67909b4de73;p=thirdparty%2Fsamba.git

lib/krb5_wrap: Fix placement of TALLOC_FREE(frame)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15727

Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Apr 23 12:14:17 UTC 2025 on atb-devel-224

(cherry picked from commit b5bd36dfd7dfd9a09a3f9378330df3be9db4551f)

Autobuild-User(v4-21-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-21-test): Wed Apr 30 16:42:48 UTC 2025 on atb-devel-224
---

diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index 0a4a7ea986f..f9d91a4f0c1 100644
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -869,16 +869,17 @@ krb5_error_code smb_krb5_parse_name_flags(krb5_context context,
 		TALLOC_FREE(frame);
 		return ENOMEM;
 	}
-	TALLOC_FREE(frame);
 
 	ret = krb5_parse_name_flags(context, utf8_name, flags, principal);
 	if (ret != KRB5_PARSE_MALFORMED) {
+		TALLOC_FREE(frame);
 		return ret;
 	}
 
 	flags |= KRB5_PRINCIPAL_PARSE_ENTERPRISE;
 	ret = krb5_parse_name_flags(context, utf8_name, flags, principal);
 
+	TALLOC_FREE(frame);
 	return ret;
 }