From: Naveen Albert <asterisk@phreaknet.org>
Date: Thu, 25 Jan 2024 17:44:29 +0000 (-0500)
Subject: manager.c: Fix erroneous reloads in UpdateConfig.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=874ee6e9aaadc9a0b5a5915d952c9f61e0967dbf;p=thirdparty%2Fasterisk.git

manager.c: Fix erroneous reloads in UpdateConfig.

Currently, a reload will always occur if the
Reload header is provided for the UpdateConfig
action. However, we should not be doing a reload
if the header value has a falsy value, per the
documentation, so this makes the reload behavior
consistent with the existing documentation.

Resolves: #551
---

diff --git a/main/manager.c b/main/manager.c
index 48231b72f9..46bcc9493b 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -4329,9 +4329,10 @@ static int action_updateconfig(struct mansession *s, const struct message *m)
 		astman_send_ack(s, m, NULL);
 		if (!ast_strlen_zero(rld)) {
 			if (ast_true(rld)) {
-				rld = NULL;
+				ast_module_reload(NULL); /* Reload everything */
+			} else if (!ast_false(rld)) {
+				ast_module_reload(rld); /* Reload the specific module */
 			}
-			ast_module_reload(rld);
 		}
 	} else {
 		ast_config_destroy(cfg);