From: Frantisek Sumsal <frantisek@sumsal.cz>
Date: Thu, 25 May 2023 09:58:32 +0000 (+0200)
Subject: sd-journal: log about errors from ordered_hashmap_*()
X-Git-Tag: v254-rc1~362^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8771463957f0fc12458aea8cc549d95183e4ee05;p=thirdparty%2Fsystemd.git

sd-journal: log about errors from ordered_hashmap_*()

Follow-up to 08a8fd6e8d.
---

diff --git a/src/libsystemd/sd-journal/catalog.c b/src/libsystemd/sd-journal/catalog.c
index 06cf396b959..f490e21490e 100644
--- a/src/libsystemd/sd-journal/catalog.c
+++ b/src/libsystemd/sd-journal/catalog.c
@@ -172,7 +172,7 @@ static int finish_item(
 
                 r = ordered_hashmap_update(h, i, combined);
                 if (r < 0)
-                        return r;
+                        return log_error_errno(r, "Failed to update catalog item: %m");
 
                 TAKE_PTR(combined);
                 free(prev);
@@ -184,7 +184,7 @@ static int finish_item(
 
                 r = ordered_hashmap_put(h, i, combined);
                 if (r < 0)
-                        return r;
+                        return log_error_errno(r, "Failed to insert catalog item: %m");
 
                 TAKE_PTR(i);
                 TAKE_PTR(combined);