From: Laurent Pinchart Date: Sun, 12 May 2024 22:21:04 +0000 (+0300) Subject: media: bcm2835-unicam: Depend on COMMON_CLK X-Git-Tag: v6.10-rc1~135^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8771b7f31b7fff91a998e6afdb60650d4bac59a5;p=thirdparty%2Flinux.git media: bcm2835-unicam: Depend on COMMON_CLK The bcm2835-unicam driver calls the clk_set_min_rate() function, which is declared but not implemented on platforms that don't provide COMMON_CLK. This causes linkage failures with some configurations. Fix it by depending on COMMON_CLK. This only slightly restricts compilation testing, but not usage of the driver as all platforms on which the hardware can be found provide COMMON_CLK. Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202405112243.2MLRT7li-lkp@intel.com/ Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/broadcom/Kconfig b/drivers/media/platform/broadcom/Kconfig index cc2c9afcc948b..32b76ebfcd9a1 100644 --- a/drivers/media/platform/broadcom/Kconfig +++ b/drivers/media/platform/broadcom/Kconfig @@ -3,7 +3,7 @@ config VIDEO_BCM2835_UNICAM tristate "Broadcom BCM283x/BCM271x Unicam video capture driver" depends on ARCH_BCM2835 || COMPILE_TEST - depends on PM + depends on COMMON_CLK && PM depends on VIDEO_DEV select MEDIA_CONTROLLER select V4L2_FWNODE