From: mkanat%bugzilla.org <>
Date: Mon, 9 Nov 2009 18:25:52 +0000 (+0000)
Subject: Bug 450747: Minor JS cleanup for the "edit multiple bugs" page
X-Git-Tag: bugzilla-3.5.2~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=877c8ef605f770b00aeda25588c963ef3d5597af;p=thirdparty%2Fbugzilla.git

Bug 450747: Minor JS cleanup for the "edit multiple bugs" page
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=mkanat, a=mkanat
---

diff --git a/template/en/default/list/edit-multiple.html.tmpl b/template/en/default/list/edit-multiple.html.tmpl
index fa8d3d1ae5..05d534976a 100644
--- a/template/en/default/list/edit-multiple.html.tmpl
+++ b/template/en/default/list/edit-multiple.html.tmpl
@@ -28,12 +28,15 @@
 <input type="hidden" name="token" value="[% token FILTER html %]">
 
 <script type="text/javascript">
-  var numelements = document.forms.changeform.elements.length;
   function SetCheckboxes(value) {
-      var item;
-      for (var i=0 ; i<numelements ; i++) {
-          item = document.forms.changeform.elements[i];
-          item.checked = value;
+      var elements = document.forms.changeform.getElementsByTagName('input'),
+          numelements = elements.length,
+          item, i;
+      for (i = 0; i < numelements; i++) {
+          item = elements[i];
+          if (item.type === 'checkbox' && item.name.match(/^id_/)) {
+            item.checked = value;
+          }
       }
   }
   document.write(' <input type="button" name="uncheck_all" value="Uncheck All" onclick="SetCheckboxes(false);">');