From: Jason Merrill <jason@redhat.com>
Date: Sun, 27 Mar 2022 13:44:59 +0000 (-0400)
Subject: c++: visibility of local extern [PR103291]
X-Git-Tag: basepoints/gcc-13~459
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8796eb27e24bd3340ebd393e96a94b91d09407e9;p=thirdparty%2Fgcc.git

c++: visibility of local extern [PR103291]

When setting up the hidden namespace-scope decl for a local extern, we also
need to set its visibility.

	PR c++/103291

gcc/cp/ChangeLog:

	* name-lookup.cc (push_local_extern_decl_alias): Call
	determine_visibility.

gcc/testsuite/ChangeLog:

	* g++.dg/ext/visibility/visibility-local-extern1.C: New test.
---

diff --git a/gcc/cp/name-lookup.cc b/gcc/cp/name-lookup.cc
index 3c7b626350f4..c833b84ca8a7 100644
--- a/gcc/cp/name-lookup.cc
+++ b/gcc/cp/name-lookup.cc
@@ -3476,6 +3476,9 @@ push_local_extern_decl_alias (tree decl)
 	      && CP_DECL_THREAD_LOCAL_P (decl)
 	      && alias != error_mark_node)
 	    set_decl_tls_model (alias, DECL_TLS_MODEL (decl));
+
+	  /* Adjust visibility.  */
+	  determine_visibility (alias);
 	}
     }
 
diff --git a/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
new file mode 100644
index 000000000000..40c20199d0cc
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/visibility/visibility-local-extern1.C
@@ -0,0 +1,10 @@
+// PR c++/103291
+// { dg-additional-options -fpic }
+// { dg-final { scan-assembler-not "@GOTPCREL" } }
+
+#pragma GCC visibility push(hidden)
+
+int hidden_fetch(void) {
+  extern const int hidden_global;
+  return hidden_global;
+}