From: Konstantinos Margaritis <konstantinos@vectorcamp.gr>
Date: Sun, 12 May 2024 17:25:29 +0000 (+0300)
Subject: nodes is never empty at this stage, emplace_back() is called just previously
X-Git-Tag: vectorscan/5.4.12^2~51^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=879cc0a18349ea64560af1aa07f4e13f7c1fb03d;p=thirdparty%2Fvectorscan.git

nodes is never empty at this stage, emplace_back() is called just previously
---

diff --git a/src/nfagraph/ng_puff.cpp b/src/nfagraph/ng_puff.cpp
index 8f130eaa..ab43d1c6 100644
--- a/src/nfagraph/ng_puff.cpp
+++ b/src/nfagraph/ng_puff.cpp
@@ -358,9 +358,7 @@ bool doComponent(RoseBuild &rose, ReportManager &rm, NGHolder &g, NFAVertex a,
         // single report ID on a vertex
         if (is_match_vertex(a, g)) {
             DEBUG_PRINTF("stop puffing due to vertex that leads to accept\n");
-            if (!nodes.empty()) {
-                nodes.pop_back();
-            }
+            nodes.pop_back();
             break;
         }
     }