From: Philip M. Gollucci Date: Fri, 6 Aug 2010 20:07:57 +0000 (+0000) Subject: rv is never used which makes the whole if useless X-Git-Tag: 2.3.7~31 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=879cfff6f47b7149e1cc4f002ee1d38c5a8ac4dd;p=thirdparty%2Fapache%2Fhttpd.git rv is never used which makes the whole if useless Reported by: clang static analyzer git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@983116 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/modules/filters/mod_reqtimeout.c b/modules/filters/mod_reqtimeout.c index 2203b61276f..f08213d3362 100644 --- a/modules/filters/mod_reqtimeout.c +++ b/modules/filters/mod_reqtimeout.c @@ -190,10 +190,7 @@ static apr_status_t reqtimeout_filter(ap_filter_t *f, #endif rv = ap_get_brigade(f->next, bb, AP_MODE_GETLINE, APR_NONBLOCK_READ, remaining); - if (APR_STATUS_IS_EAGAIN(rv)) { - rv = APR_SUCCESS; - } - else if (rv != APR_SUCCESS) { + if (rv != APR_SUCCESS) { break; }