From: Jan Engelhardt <jengelh@medozas.de>
Date: Sat, 10 Jan 2009 03:46:26 +0000 (+0100)
Subject: ipp2p: remove log flooding
X-Git-Tag: v1.8~3^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=879e964f60dad2bb55553cd119f1a8d881caed0e;p=thirdparty%2Fxtables-addons.git

ipp2p: remove log flooding

Syslog was flooded by lots of messages due to if (plen >= 5) firing
on any packet, when it should have been plen < 5. Incidentally, this
turned up that plen also takes on huge nonsense values, assuming
underflow - yet to be investigated.
---

diff --git a/extensions/xt_ipp2p.c b/extensions/xt_ipp2p.c
index 9c407ea..16203f9 100644
--- a/extensions/xt_ipp2p.c
+++ b/extensions/xt_ipp2p.c
@@ -603,8 +603,13 @@ search_all_kazaa(const unsigned char *payload, const unsigned int plen)
 {
 	uint16_t c, end, rem;
 
-	if (plen >= 5) {
-		printk(KERN_WARNING KBUILD_MODNAME ": %s: plen (%u) < 5\n",
+	if (plen < 5)
+		/* too short for anything we test for - early bailout */
+		return 0;
+
+	if (plen >= 65535) {
+		/* Something seems _really_ fishy */
+		printk(KERN_WARNING KBUILD_MODNAME ": %s: plen (%u) >= 65535\n",
 		       __func__, plen);
 		return 0;
 	}