From: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
Date: Sun, 30 Oct 2022 23:07:11 +0000 (-0400)
Subject: gh-98879: Remove unreachable error case from COMPARE_OP_STR_JUMP (GH-98882)
X-Git-Tag: v3.12.0a2~194
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=87b5fd9d9de11c68b9940d3a1dba902138129109;p=thirdparty%2FPython%2Fcpython.git

gh-98879: Remove unreachable error case from COMPARE_OP_STR_JUMP (GH-98882)

Thanks to PEP 623 changes, the comparison cannot fail.
---

diff --git a/Python/ceval.c b/Python/ceval.c
index 24af419d29c5..f2250ffbc71f 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -3420,9 +3420,6 @@ handle_eval_breaker:
             DEOPT_IF(!PyUnicode_CheckExact(right), COMPARE_OP);
             STAT_INC(COMPARE_OP, hit);
             int res = _PyUnicode_Equal(left, right);
-            if (res < 0) {
-                goto error;
-            }
             assert(oparg == Py_EQ || oparg == Py_NE);
             JUMPBY(INLINE_CACHE_ENTRIES_COMPARE_OP);
             NEXTOPARG();