From: Ján Tomko <jtomko@redhat.com>
Date: Sat, 15 Jun 2019 10:06:36 +0000 (+0200)
Subject: tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE
X-Git-Tag: v5.5.0-rc1~260
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=87bd4377779d49ba9fefb6215a979fc67a2a2c46;p=thirdparty%2Flibvirt.git

tests: qemuMonitorTestAddErrorResponse: use VIR_AUTOFREE

Use VIR_AUTOFREE.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c
index 86883e682b..bb30bed51e 100644
--- a/tests/qemumonitortestutils.c
+++ b/tests/qemumonitortestutils.c
@@ -124,11 +124,10 @@ qemuMonitorTestAddErrorResponse(qemuMonitorTestPtr test,
                                 const char *usermsg)
 {
     virBuffer buf = VIR_BUFFER_INITIALIZER;
-    char *escapemsg = NULL;
-    char *jsonmsg = NULL;
+    VIR_AUTOFREE(char *) escapemsg = NULL;
+    VIR_AUTOFREE(char *) jsonmsg = NULL;
     const char *monmsg = NULL;
     char *tmp;
-    int ret = -1;
 
     if (!usermsg)
         usermsg = "unexpected command";
@@ -136,7 +135,7 @@ qemuMonitorTestAddErrorResponse(qemuMonitorTestPtr test,
     if (test->json || test->agent) {
         virBufferEscape(&buf, '\\', "\"", "%s", usermsg);
         if (virBufferCheckError(&buf) < 0)
-            goto error;
+            return -1;
         escapemsg = virBufferContentAndReset(&buf);
 
         /* replace newline/carriage return with space */
@@ -153,19 +152,14 @@ qemuMonitorTestAddErrorResponse(qemuMonitorTestPtr test,
                                   " { \"desc\": \"%s\", "
                                   "   \"class\": \"UnexpectedCommand\" } }",
                                   escapemsg) < 0)
-            goto error;
+            return -1;
 
         monmsg = jsonmsg;
     } else {
         monmsg = usermsg;
     }
 
-    ret = qemuMonitorTestAddResponse(test, monmsg);
-
- error:
-    VIR_FREE(escapemsg);
-    VIR_FREE(jsonmsg);
-    return ret;
+    return qemuMonitorTestAddResponse(test, monmsg);
 }