From: Tobias Stoeckmann <tobias@stoeckmann.org>
Date: Fri, 9 Jan 2026 16:20:07 +0000 (+0100)
Subject: su: Turn caught into volatile sig_atomic_t
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8800423a8af64b6b9a65464021228aa26eaece1b;p=thirdparty%2Fshadow.git

su: Turn caught into volatile sig_atomic_t

Only these shared variables can be safely written to by signal handlers.

Reviewed-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Ruihan Li <lrh2000@pku.edu.cn>
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
---

diff --git a/src/su.c b/src/su.c
index e5ee84428..8c355d07f 100644
--- a/src/su.c
+++ b/src/su.c
@@ -97,7 +97,7 @@ static bool change_environment = true;
 static char kill_msg[256];
 static char wait_msg[256];
 static pam_handle_t *pamh = NULL;
-static int caught = 0;
+static volatile sig_atomic_t caught = 0;
 /* PID of the child, in case it needs to be killed */
 static pid_t pid_child = 0;
 #endif