From: Amos Jeffries <squid3@treenet.co.nz>
Date: Sun, 20 Jan 2013 04:37:30 +0000 (-0700)
Subject: Polish: zero-initialize WCCPv2 security object
X-Git-Tag: SQUID_3_4_0_1~367
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=883dcc9ca570d1b7f0945b5079400da44e2b56a7;p=thirdparty%2Fsquid.git

Polish: zero-initialize WCCPv2 security object

Most of the objects fields are initialized later individually and the
rest SHOULD not matter. But it is better to be safe than sorry in this
area.

 Detected by Coverity Scan. Issue 740505.
---

diff --git a/src/wccp2.cc b/src/wccp2.cc
index 5267a7726d..8861dd8c99 100644
--- a/src/wccp2.cc
+++ b/src/wccp2.cc
@@ -681,8 +681,6 @@ wccp2Init(void)
 
     struct wccp2_router_list_t *router_list_ptr;
 
-    struct wccp2_security_md5_t wccp2_security_md5;
-
     debugs(80, 5, "wccp2Init: Called");
 
     if (wccp2_connected == 1)
@@ -702,6 +700,9 @@ wccp2Init(void)
         return;
     }
 
+    struct wccp2_security_md5_t wccp2_security_md5;
+    memset(&wccp2_security_md5, 0, sizeof(wccp2_security_md5));
+
     /* Initialise the list of services */
     wccp2InitServices();