From: Jeremy Allison <jra@samba.org>
Date: Thu, 2 Dec 2021 00:25:03 +0000 (-0800)
Subject: s3: smbd: Prepare to remove wildcard matching from rename_internals().
X-Git-Tag: tdb-1.4.6~385
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=885a982b9fde950e80862c481ee711a9e16403b2;p=thirdparty%2Fsamba.git

s3: smbd: Prepare to remove wildcard matching from rename_internals().

src_has_wild and dest_has_wild can never be true.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index fabeb400046..9a94693d937 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -7872,20 +7872,6 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
 		goto out;
 	}
 
-	if (!(smb_fname_src->flags & SMB_FILENAME_POSIX_PATH)) {
-		/*
-		 * Check the wildcard mask *before*
-		 * unmangling. As mangling is done
-		 * for names that can't be returned
-		 * to Windows the unmangled name may
-		 * contain Windows wildcard characters.
-		 */
-		if (src_original_lcomp != NULL) {
-			src_has_wild = ms_has_wild(src_original_lcomp);
-		}
-		dest_has_wild = ms_has_wild(dst_original_lcomp);
-	}
-
 	/*
 	 * We should only check the mangled cache
 	 * here if unix_convert failed. This means