From: Simon McVittie <smcv@collabora.com>
Date: Wed, 11 Jul 2018 15:14:27 +0000 (+0100)
Subject: dbus_server_listen: Assert that implementations return a known result
X-Git-Tag: dbus-1.13.6~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8868aac95d55d41c89aee36946e72ba561fb719c;p=thirdparty%2Fdbus.git

dbus_server_listen: Assert that implementations return a known result

If they didn't, we'd probably leak the server and/or the error.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=107194
---

diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c
index f26a8f7c1..3243af6c9 100644
--- a/dbus/dbus-server.c
+++ b/dbus/dbus-server.c
@@ -631,6 +631,10 @@ dbus_server_listen (const char     *address,
               
               /* keep trying addresses */
             }
+          else
+            {
+              _dbus_assert_not_reached ("Unknown result in dbus_server_listen");
+            }
         }
 
       _dbus_assert (server == NULL);