From: Steffan Karger Date: Fri, 8 Dec 2017 09:12:18 +0000 (+0100) Subject: Fix memory leak in buffer unit tests X-Git-Tag: v2.4.5~40 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=888204a1e9a4278a62e9a1cb0ea1c0cdff95473e;p=thirdparty%2Fopenvpn.git Fix memory leak in buffer unit tests buffer_list_push_data does not take ownership of the memory, so just feed it stack data to plug the leak. Signed-off-by: Steffan Karger Acked-by: Antonio Quartulli Message-Id: <1512724338-22197-1-git-send-email-steffan@karger.me> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16055.html Signed-off-by: Gert Doering (cherry picked from commit 2c7c760dfbddbc9cf348bce06fa922c1217a2039) --- diff --git a/tests/unit_tests/openvpn/test_buffer.c b/tests/unit_tests/openvpn/test_buffer.c index ba5aa6704..c2b7f30f0 100644 --- a/tests/unit_tests/openvpn/test_buffer.c +++ b/tests/unit_tests/openvpn/test_buffer.c @@ -77,10 +77,9 @@ static int test_buffer_list_setup(void **state) buffer_list_push(ctx->zero_length_strings, ""); ctx->empty_buffers = buffer_list_new(2); - uint8_t *data1 = malloc(1); - uint8_t *data2 = malloc(1); - buffer_list_push_data(ctx->empty_buffers, data1, 0); - buffer_list_push_data(ctx->empty_buffers, data2, 0); + uint8_t data = 0; + buffer_list_push_data(ctx->empty_buffers, &data, 0); + buffer_list_push_data(ctx->empty_buffers, &data, 0); *state = ctx; return 0;