From: Stephen Finucane <stephen@that.guru>
Date: Thu, 6 Sep 2018 14:53:09 +0000 (+0100)
Subject: tests: Hardcode expected values
X-Git-Tag: v2.2.0-rc1~239
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8883380269e22c61c91159a31992f8806bc27c79;p=thirdparty%2Fpatchwork.git

tests: Hardcode expected values

Compare against known values to ensure bugs introduced in the function
are caught.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Reviewed-by: Daniel Axtens <dja@axtens.net>
---

diff --git a/patchwork/tests/test_series.py b/patchwork/tests/test_series.py
index bb44e39d..ff3412e6 100644
--- a/patchwork/tests/test_series.py
+++ b/patchwork/tests/test_series.py
@@ -623,10 +623,6 @@ class SeriesNameTestCase(TestCase):
     def _parse_mail(self, mail):
         return parser.parse_mail(mail, self.project.listid)
 
-    @staticmethod
-    def _format_name(cover):
-        return models.Series._format_name(cover)
-
     def test_cover_letter(self):
         """Cover letter name set as series name.
 
@@ -642,7 +638,7 @@ class SeriesNameTestCase(TestCase):
         mbox = self._get_mbox('base-cover-letter.mbox')
 
         cover = self._parse_mail(mbox[0])
-        cover_name = self._format_name(cover)
+        cover_name = 'A sample series'
         self.assertEqual(cover.series.first().name, cover_name)
 
         self._parse_mail(mbox[1])
@@ -697,7 +693,7 @@ class SeriesNameTestCase(TestCase):
         self.assertEqual(patch.series.first().name, patch.name)
 
         cover = self._parse_mail(mbox[2])
-        self.assertEqual(cover.series.first().name, self._format_name(cover))
+        self.assertEqual(cover.series.first().name, 'A sample series')
 
         mbox.close()