From: Mike Bayer Date: Fri, 4 Feb 2022 20:46:41 +0000 (-0500) Subject: amend verbiage for #7667's changelog message X-Git-Tag: rel_2_0_0b1~498 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88bc4f2f66cffe82ed039a622027abd54897280a;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git amend verbiage for #7667's changelog message clarify this applies to async calling styles only. Change-Id: I42286fe2651be13bd472fac981df9de276ed9bb1 --- diff --git a/doc/build/changelog/unreleased_14/7667.rst b/doc/build/changelog/unreleased_14/7667.rst index d66572feb0..34dcd44b0b 100644 --- a/doc/build/changelog/unreleased_14/7667.rst +++ b/doc/build/changelog/unreleased_14/7667.rst @@ -5,11 +5,14 @@ Fixed issue where the :meth:`_asyncio.AsyncSession.execute` method failed to raise an informative exception if the ``stream_results`` execution option were used, which is incompatible with a sync-style - :class:`_result.Result` object. An exception is now raised in this scenario - in the same way one is already raised when using ``stream_results`` in - conjunction with the :meth:`_asyncio.AsyncConnection.execute` method. - Additionally, for improved stability with state-sensitive dialects such as - asyncmy, the cursor is now closed when this error condition is raised; - previously with the asyncmy dialect, the connection would go into an - invalid state with unconsumed server side results remaining. + :class:`_result.Result` object when using an asyncio calling style, as the + operation to fetch more rows would need to be awaited. An exception is now + raised in this scenario in the same way one was already raised when the + ``stream_results`` option would be used with the + :meth:`_asyncio.AsyncConnection.execute` method. + + Additionally, for improved stability with state-sensitive database drivers + such as asyncmy, the cursor is now closed when this error condition is + raised; previously with the asyncmy dialect, the connection would go into + an invalid state with unconsumed server side results remaining.