From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Mon, 11 Mar 2019 09:13:01 +0000 (+0100)
Subject: DNAME: Add comment in the tests
X-Git-Tag: rec-4.2.0-beta1~6^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88bc98dc2346cec87f11059d24719e93be427878;p=thirdparty%2Fpdns.git

DNAME: Add comment in the tests
---

diff --git a/pdns/recursordist/test-syncres_cc.cc b/pdns/recursordist/test-syncres_cc.cc
index fbdb287a5b..a02f9ba3d3 100644
--- a/pdns/recursordist/test-syncres_cc.cc
+++ b/pdns/recursordist/test-syncres_cc.cc
@@ -10955,6 +10955,9 @@ BOOST_AUTO_TEST_CASE(test_dname_dnssec_secure) {
 
   sr->setAsyncCallback([dnameOwner, dnameTarget, target, cnameTarget, keys, &queries](const ComboAddress& ip, const DNSName& domain, int type, bool doTCP, bool sendRDQuery, int EDNS0Level, struct timeval* now, boost::optional<Netmask>& srcmask, boost::optional<const ResolveContext&> context, LWResult* res, bool* chained) {
       queries++;
+      /* We don't use the genericDSAndDNSKEYHandler here, as it would deny names existing at the wrong level of the tree, due to the way computeZoneCuts works
+       * As such, we need to do some more work to make the answers correct.
+       */
 
       if (isRootServer(ip)) {
         if (domain.countLabels() == 0 && type == QType::DNSKEY) { // .|DNSKEY