From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 3 Nov 2011 15:52:35 +0000 (-0400)
Subject: Fix bug 4367: correctly detect auth_challenge cells we can't use
X-Git-Tag: tor-0.2.3.8-alpha~33^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88c4b425bd49d4cde52fdce7eeb65bcf2304d0f6;p=thirdparty%2Ftor.git

Fix bug 4367: correctly detect auth_challenge cells we can't use

Found by frosty_un, bugfix on 0.2.3.6-alpha, fix suggested by arma.
---

diff --git a/changes/bug4367 b/changes/bug4367
new file mode 100644
index 0000000000..77236d0e61
--- /dev/null
+++ b/changes/bug4367
@@ -0,0 +1,5 @@
+  o Minor bugfixes:
+    - Successfully detect AUTH_CHALLENGE cells with no recognized
+      authentication type listed. Fixes bug 4367; bugfix on 0.2.3.6-alpha.
+      Found by frosty_un.
+
diff --git a/src/or/command.c b/src/or/command.c
index c02d353bb1..6eb261c370 100644
--- a/src/or/command.c
+++ b/src/or/command.c
@@ -1100,7 +1100,7 @@ command_process_auth_challenge_cell(var_cell_t *cell, or_connection_t *conn)
 
   conn->handshake_state->received_auth_challenge = 1;
 
-  if (use_type && public_server_mode(get_options())) {
+  if (use_type >= 0 && public_server_mode(get_options())) {
     log_info(LD_OR, "Got an AUTH_CHALLENGE cell from %s:%d: Sending "
              "authentication",
              safe_str(conn->_base.address), conn->_base.port);