From: Tim Beale Date: Sun, 25 Nov 2018 22:58:31 +0000 (+1300) Subject: tests: Use s3 smbclient for testenv smoketests X-Git-Tag: tdb-1.3.17~640 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88ccd418fdee67ef8f2e4c06acc1488a875c641e;p=thirdparty%2Fsamba.git tests: Use s3 smbclient for testenv smoketests smbclient4 doesn't support SMBv2 connections, i.e. it won't work against a DC with SMBv1 disabled. The smoke-test here is that the DC accepts the connection, so we don't really care what SMB tool we use to connect. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676 Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett --- diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py index 6a1e1448ef9..37b7a04c1fb 100755 --- a/source4/selftest/tests.py +++ b/source4/selftest/tests.py @@ -971,7 +971,7 @@ for env in ['rodc', 'offlinebackupdc', 'restoredc', 'renamedc', 'labdc']: plansmbtorture4testsuite('rpc.echo', "%s:local" % env, ['ncacn_np:$SERVER', "-k", "yes", '-P', '--workgroup=$DOMAIN'], modname="samba4.rpc.echo") plansmbtorture4testsuite('rpc.echo', "%s:local" % env, ['ncacn_np:$SERVER', "-k", "no", '-Utestallowed\ account%$DC_PASSWORD', '--workgroup=$DOMAIN'], modname="samba4.rpc.echo.testallowed") plansmbtorture4testsuite('rpc.echo', "%s:local" % env, ['ncacn_np:$SERVER', "-k", "no", '-Utestdenied%$DC_PASSWORD', '--workgroup=$DOMAIN'], modname="samba4.rpc.echo.testdenied") - plantestsuite("samba4.blackbox.smbclient(%s:local)" % env, "%s:local" % env, [os.path.join(samba4srcdir, "utils/tests/test_smbclient.sh"), '$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', '$DOMAIN', smbclient4]) + plantestsuite("samba4.blackbox.smbclient(%s:local)" % env, "%s:local" % env, [os.path.join(samba4srcdir, "utils/tests/test_smbclient.sh"), '$SERVER', '$SERVER_IP', '$USERNAME', '$PASSWORD', '$DOMAIN', binpath('smbclient')]) planpythontestsuite("rodc:local", "samba.tests.samba_tool.rodc", py3_compatible=True)