From: Rob van der Linde Date: Tue, 7 Nov 2023 20:44:14 +0000 (+1300) Subject: netcmd: tests: update silo member grant and revoke docstings and comments X-Git-Tag: talloc-2.4.2~735 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88ea6b17e17a129d3c4135f0fb42c739effa8f17;p=thirdparty%2Fsamba.git netcmd: tests: update silo member grant and revoke docstings and comments Signed-off-by: Rob van der Linde Reviewed-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/samba_tool/domain_auth_silo.py b/python/samba/tests/samba_tool/domain_auth_silo.py index f49c1cf4474..a1cd85c8f05 100644 --- a/python/samba/tests/samba_tool/domain_auth_silo.py +++ b/python/samba/tests/samba_tool/domain_auth_silo.py @@ -509,7 +509,7 @@ class AuthSiloMemberCmdTestCase(SiloTest): self.samdb.create_ou(self.ou) self.addCleanup(self.samdb.delete, self.ou, ["tree_delete:1"]) - # Assign members to silos + # Grant member access to silos self.grant_silo_access("Developers", "bob") self.grant_silo_access("Developers", "jane") self.grant_silo_access("Managers", "alice") @@ -521,7 +521,7 @@ class AuthSiloMemberCmdTestCase(SiloTest): return dn def grant_silo_access(self, silo, member): - """Add a member to an authentication silo.""" + """Grant a member access to an authentication silo.""" result, out, err = self.runcmd("domain", "auth", "silo", "member", "grant", "--name", silo, "--member", member) @@ -533,7 +533,7 @@ class AuthSiloMemberCmdTestCase(SiloTest): self.addCleanup(self.revoke_silo_access, silo, member) def revoke_silo_access(self, silo, member): - """Remove a member to an authentication silo.""" + """Revoke a member from an authentication silo.""" result, out, err = self.runcmd("domain", "auth", "silo", "member", "revoke", "--name", silo, "--member", member) @@ -596,7 +596,7 @@ class AuthSiloMemberCmdTestCase(SiloTest): computer = self.create_computer(name) silo = "Developers" - # Don't use self.add_silo_member as it will try to clean up the user. + # Don't use self.grant_silo_member as it will try to clean up the user. result, out, err = self.runcmd("domain", "auth", "silo", "member", "grant", "--name", silo,