From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 14 Oct 2025 13:20:52 +0000 (+0200)
Subject: Fixes from code review by @rgacogne
X-Git-Tag: rec-5.4.0-alpha1~190^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88edf615cad0df18ce04580b3ef7b68dc70e20f3;p=thirdparty%2Fpdns.git

Fixes from code review by @rgacogne

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index f272dff790..55149fa15c 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -2124,7 +2124,6 @@ static int serviceMain(Logr::log_t log)
   }
   g_maxCacheEntries = ::arg().asNum("max-cache-entries");
 
-  cerr << "CALL LUACONFIG" << endl;
   auto luaResult = luaconfig(false);
   if (luaResult.d_ret != 0) {
     log->error(Logr::Error, luaResult.d_str, "Cannot load Lua or equivalent YAML configuration");
diff --git a/pdns/tcpiohandler.cc b/pdns/tcpiohandler.cc
index 0d034e0326..3dfd588246 100644
--- a/pdns/tcpiohandler.cc
+++ b/pdns/tcpiohandler.cc
@@ -42,7 +42,7 @@ bool shouldDoVerboseLogging()
 #ifdef DNSDIST
   return dnsdist::configuration::getCurrentRuntimeConfiguration().d_verbose;
 #elif defined(RECURSOR)
-  return true;
+  return false;
 #else
   return true;
 #endif
@@ -575,10 +575,10 @@ public:
           X509_free(cert);
         }
       }
-      const auto* errorMsg = X509_verify_cert_error_string(errorCode);
       if (!certPresented) {
         return {-1, "No certificate presented by peer"};
       }
+      const auto* errorMsg = X509_verify_cert_error_string(errorCode);
       return {errorCode, errorMsg != nullptr ? errorMsg : "No details available"};
     }
     return {0, ""};