From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Sun, 27 Jan 2008 02:21:23 +0000 (+0000)
Subject: - Fixed bug in polymorphic inheritance where incorrect
X-Git-Tag: rel_0_4_3~68
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88f42cf1f4baa9818dfb014ac4e162ce345a4459;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- Fixed bug in polymorphic inheritance where incorrect
exception is raised when base polymorphic_on
column does not correspond to any columns within
the local selectable of an inheriting mapper more
than one level deep
---

diff --git a/CHANGES b/CHANGES
index e39f891a45..069192a445 100644
--- a/CHANGES
+++ b/CHANGES
@@ -83,6 +83,12 @@ CHANGES
       need to be sent to query.get(), among other things.
       [ticket:933]
 
+    - Fixed bug in polymorphic inheritance where incorrect
+      exception is raised when base polymorphic_on
+      column does not correspond to any columns within 
+      the local selectable of an inheriting mapper more 
+      than one level deep
+      
     - Fixed bug in polymorphic inheritance which made it
       difficult to set a working "order_by" on a polymorphic
       mapper.
diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py
index d9dc70a585..959cf274c4 100644
--- a/lib/sqlalchemy/orm/mapper.py
+++ b/lib/sqlalchemy/orm/mapper.py
@@ -352,9 +352,14 @@ class Mapper(object):
             if self.polymorphic_identity is not None:
                 self.inherits.polymorphic_map[self.polymorphic_identity] = self
                 if self.polymorphic_on is None:
-                    if self.inherits.polymorphic_on is not None:
-                        self.polymorphic_on = self.mapped_table.corresponding_column(self.inherits.polymorphic_on)
+                    for mapper in self.iterate_to_root():
+                        # try to set up polymorphic on using correesponding_column(); else leave
+                        # as None
+                        if mapper.polymorphic_on:
+                            self.polymorphic_on = self.mapped_table.corresponding_column(mapper.polymorphic_on)
+                            break
                     else:
+                        # TODO: this exception not covered
                         raise exceptions.ArgumentError("Mapper '%s' specifies a polymorphic_identity of '%s', but no mapper in it's hierarchy specifies the 'polymorphic_on' column argument" % (str(self), self.polymorphic_identity))
 
             if self.polymorphic_identity is not None and not self.concrete:
diff --git a/test/orm/inheritance/polymorph2.py b/test/orm/inheritance/polymorph2.py
index 0f0fff6729..75ec0c2b5a 100644
--- a/test/orm/inheritance/polymorph2.py
+++ b/test/orm/inheritance/polymorph2.py
@@ -1010,6 +1010,54 @@ class InheritingEagerTest(ORMTest):
         instance = session.query(Employee).filter_by(id=1).limit(1).first()
         assert len(instance.tags) == 2
 
-
+class MissingPolymorphicOnTest(ORMTest):
+    def define_tables(self, metadata):
+        global tablea, tableb, tablec, tabled
+        tablea = Table('tablea', metadata, 
+            Column('id', Integer, primary_key=True),
+            Column('adata', String(50)),
+            )
+        tableb = Table('tableb', metadata, 
+            Column('id', Integer, primary_key=True),
+            Column('aid', Integer, ForeignKey('tablea.id')),
+            Column('data', String(50)),
+            )
+        tablec = Table('tablec', metadata, 
+            Column('id', Integer, ForeignKey('tablea.id'), primary_key=True),
+            Column('cdata', String(50)),
+            )
+        tabled = Table('tabled', metadata, 
+            Column('id', Integer, ForeignKey('tablec.id'), primary_key=True),
+            Column('ddata', String(50)),
+            )
+            
+    def test_polyon_col_setsup(self):
+        class A(fixtures.Base):
+            pass
+        class B(fixtures.Base):
+            pass
+        class C(A):
+            pass
+        class D(C):
+            pass
+            
+        poly_select = select([tablea, tableb.c.data.label('discriminator')], from_obj=tablea.join(tableb)).alias('poly')
+        
+        mapper(B, tableb)
+        mapper(A, tablea, select_table=poly_select, polymorphic_on=poly_select.c.discriminator, properties={
+            'b':relation(B, uselist=False)
+        })
+        mapper(C, tablec, inherits=A,polymorphic_identity='c')
+        mapper(D, tabled, inherits=C, polymorphic_identity='d')
+        
+        c = C(cdata='c1', adata='a1', b=B(data='c'))
+        d = D(cdata='c2', adata='a2', ddata='d2', b=B(data='d'))
+        sess = create_session()
+        sess.save(c)
+        sess.save(d)
+        sess.flush()
+        sess.clear()
+        self.assertEquals(sess.query(A).all(), [C(cdata='c1', adata='a1'), D(cdata='c2', adata='a2', ddata='d2')])
+        
 if __name__ == "__main__":
     testenv.main()