From: Razvan Becheriu <razvan@isc.org>
Date: Tue, 20 Oct 2020 11:24:54 +0000 (+0300)
Subject: [#1423] Addressed comments
X-Git-Tag: Kea-1.9.1~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=88fd53246fc2e2f5f4657ed24f22098a289bbe24;p=thirdparty%2Fkea.git

[#1423] Addressed comments
---

diff --git a/src/bin/d2/tests/parser_unittest.cc b/src/bin/d2/tests/parser_unittest.cc
index d6b8c58ab4..d44fe8057d 100644
--- a/src/bin/d2/tests/parser_unittest.cc
+++ b/src/bin/d2/tests/parser_unittest.cc
@@ -12,6 +12,7 @@
 #include <testutils/user_context_utils.h>
 #include <gtest/gtest.h>
 #include <fstream>
+#include <set>
 
 #include "test_data_files_config.h"
 
diff --git a/src/bin/d2/tests/parser_unittest.h b/src/bin/d2/tests/parser_unittest.h
index 7b22c9d070..bcefcb788f 100644
--- a/src/bin/d2/tests/parser_unittest.h
+++ b/src/bin/d2/tests/parser_unittest.h
@@ -10,7 +10,6 @@
 #include <gtest/gtest.h>
 #include <cc/data.h>
 #include <d2/parser_context.h>
-#include <set>
 
 using namespace isc::data;
 using namespace std;
diff --git a/src/bin/dhcp4/tests/parser_unittest.cc b/src/bin/dhcp4/tests/parser_unittest.cc
index e620fbbc7f..159a216066 100644
--- a/src/bin/dhcp4/tests/parser_unittest.cc
+++ b/src/bin/dhcp4/tests/parser_unittest.cc
@@ -695,7 +695,7 @@ void loadFile(const string& fname, ElementPtr list) {
     list->add(json);
 }
 
-// This test checks that all map entries are in the all-keys file.
+// This test checks that all map entries are in the example files.
 TEST(ParserTest, mapEntries) {
     // Type of keyword set.
     typedef set<string> KeywordSet;
@@ -731,7 +731,7 @@ TEST(ParserTest, mapEntries) {
     }
     syntax_file.close();
 
-    // Get keywords from the all-keys and reservations file
+    // Get keywords from the example files.
     string sample_dir(CFG_EXAMPLES);
     sample_dir += "/";
     ElementPtr sample_json = Element::createList();
diff --git a/src/bin/dhcp6/tests/parser_unittest.cc b/src/bin/dhcp6/tests/parser_unittest.cc
index 79b6f2766e..e9b9a0787a 100644
--- a/src/bin/dhcp6/tests/parser_unittest.cc
+++ b/src/bin/dhcp6/tests/parser_unittest.cc
@@ -684,7 +684,7 @@ void loadFile(const string& fname, ElementPtr list) {
     list->add(json);
 }
 
-// This test checks that all map entries are in the all-keys file.
+// This test checks that all map entries are in the example files.
 TEST(ParserTest, mapEntries) {
     // Type of keyword set.
     typedef set<string> KeywordSet;
@@ -729,7 +729,7 @@ TEST(ParserTest, mapEntries) {
     loadFile(sample_dir + "duid.json", sample_json);
     loadFile(sample_dir + "reservations.json", sample_json);
     KeywordSet sample_keys = {
-        "hosts-database",
+        "hosts-database"
     };
     // Recursively extract keywords.
     static void (*extract)(ConstElementPtr, KeywordSet&) =