From: Jason A. Donenfeld <Jason@zx2c4.com>
Date: Fri, 18 Dec 2020 15:41:49 +0000 (+0100)
Subject: conn: do not SO_REUSEADDR on linux
X-Git-Tag: 0.0.20210212~118
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=890cc06ed577420b04676d4b2d7a7daae5fb0030;p=thirdparty%2Fwireguard-go.git

conn: do not SO_REUSEADDR on linux

SO_REUSEADDR does not make sense for unicast UDP sockets.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---

diff --git a/conn/conn_linux.go b/conn/conn_linux.go
index 08c8949..ef98100 100644
--- a/conn/conn_linux.go
+++ b/conn/conn_linux.go
@@ -326,15 +326,6 @@ func create4(port uint16) (int, uint16, error) {
 	// set sockopts and bind
 
 	if err := func() error {
-		if err := unix.SetsockoptInt(
-			fd,
-			unix.SOL_SOCKET,
-			unix.SO_REUSEADDR,
-			1,
-		); err != nil {
-			return err
-		}
-
 		if err := unix.SetsockoptInt(
 			fd,
 			unix.IPPROTO_IP,
@@ -379,16 +370,6 @@ func create6(port uint16) (int, uint16, error) {
 	}
 
 	if err := func() error {
-
-		if err := unix.SetsockoptInt(
-			fd,
-			unix.SOL_SOCKET,
-			unix.SO_REUSEADDR,
-			1,
-		); err != nil {
-			return err
-		}
-
 		if err := unix.SetsockoptInt(
 			fd,
 			unix.IPPROTO_IPV6,