From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Thu, 9 Dec 2021 05:06:15 +0000 (+1300)
Subject: s3/torture/pdbtest: fix always false condition
X-Git-Tag: tevent-0.12.0~836
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=891201f154a2ca05b7fc8ec78492a79ee0bddafe;p=thirdparty%2Fsamba.git

s3/torture/pdbtest: fix always false condition

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9320

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/torture/pdbtest.c b/source3/torture/pdbtest.c
index 67a1aa0b2d5..d3895127af2 100644
--- a/source3/torture/pdbtest.c
+++ b/source3/torture/pdbtest.c
@@ -191,7 +191,7 @@ static bool samu_correct(struct samu *s1, struct samu *s2)
 	} else if (pdb_get_hours_len(s1) != 0) {
 		d1_buf = pdb_get_hours(s1);
 		d2_buf = pdb_get_hours(s2);
-		if (d2_buf == NULL && d2_buf != NULL) {
+		if (d2_buf == NULL && d1_buf != NULL) {
 			DEBUG(0, ("Logon hours is not set\n"));
 			ret = False;
 		} else if (d1_buf == NULL) {