From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 17 Feb 2023 23:03:57 +0000 (-0500)
Subject: DEFINEs in number-based protocols are always internal
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=891747c5afd0e1fe37939f33a84fe01484716a39;p=thirdparty%2Ffreeradius-server.git

DEFINEs in number-based protocols are always internal
---

diff --git a/src/lib/util/dict_validate.c b/src/lib/util/dict_validate.c
index da8b83a79c3..98671dfe884 100644
--- a/src/lib/util/dict_validate.c
+++ b/src/lib/util/dict_validate.c
@@ -658,8 +658,11 @@ bool dict_attr_fields_valid(fr_dict_t *dict, fr_dict_attr_t const *parent,
 		 *	If we don't care about the number, then this attribute is almost always
 		 *	an internal one.  Unless it's a "name only" attribute for string-based
 		 *	protocols.
+		 *
+		 *	We can use DEFINE in number-based protocol dictionaries, and the attributes will be
+		 *	marked up as "internal".
 		 */
-		flags->internal |= !flags->name_only;
+		flags->internal |= !flags->name_only | !dict->string_based;
 
 		v = fr_dict_attr_by_name(NULL, fr_dict_root(dict), name);
 		if (v) {