From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 22 Jan 2026 09:16:24 +0000 (+0100)
Subject: daemon/io_create() nits
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=891793673cede9e9f62d2ae46d06e4901c78be8e;p=thirdparty%2Fknot-resolver.git

daemon/io_create() nits
---

diff --git a/daemon/io.c b/daemon/io.c
index 2f06f1a8e..cd60e7443 100644
--- a/daemon/io.c
+++ b/daemon/io.c
@@ -381,7 +381,7 @@ static void tcp_accept_internal(uv_stream_t *master, int status, enum kr_proto g
 		return;
 	}
 
-	uv_handle_t *client = { 0 };
+	uv_handle_t *client;
 	if (io_create(master->loop, &client, SOCK_STREAM, AF_UNSPEC)) {
 		return;
 	}
@@ -930,8 +930,9 @@ int io_create(uv_loop_t *loop, uv_handle_t **handle,
 		uv_tcp_t *tcp = malloc(sizeof(uv_tcp_t));
 		kr_require(tcp);
 		ret = uv_tcp_init_ex(loop, tcp, family);
-		uv_tcp_nodelay(tcp, 1);
-
+		if (ret != 0) {
+			uv_tcp_nodelay(tcp, 1);
+		}
 		*handle = (uv_handle_t *)tcp;
 	} else {
 		kr_require(false && "io_create: invalid socket type");
diff --git a/daemon/worker.c b/daemon/worker.c
index 31774aef9..3ac3f844a 100644
--- a/daemon/worker.c
+++ b/daemon/worker.c
@@ -157,7 +157,7 @@ static struct session2 *ioreq_spawn(int socktype, sa_family_t family,
 	}
 
 	/* Create connection for iterative query */
-	uv_handle_t *handle = { 0 };
+	uv_handle_t *handle;
 	if (io_create(the_worker->loop, &handle, socktype, family)) {
 		return NULL;
 	}