From: Mark Andrews Date: Wed, 5 Feb 2020 05:53:43 +0000 (+1100) Subject: 'dispatch' must be non NULL, remove test. X-Git-Tag: v9.16.0~29^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=891f24fa57ae8fba02eb21f32ce5fb40a080efc9;p=thirdparty%2Fbind9.git 'dispatch' must be non NULL, remove test. 10067 cleanup: CID 1452683 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking dispatch suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 10068 if (dispatch != NULL) 10069 isc_mem_put(server->mctx, dispatch, sizeof(*dispatch)); --- diff --git a/bin/named/server.c b/bin/named/server.c index 3acd9ad0e64..6a818a31493 100644 --- a/bin/named/server.c +++ b/bin/named/server.c @@ -10065,8 +10065,7 @@ named_add_reserved_dispatch(named_server_t *server, return; cleanup: - if (dispatch != NULL) - isc_mem_put(server->mctx, dispatch, sizeof(*dispatch)); + isc_mem_put(server->mctx, dispatch, sizeof(*dispatch)); isc_sockaddr_format(addr, addrbuf, sizeof(addrbuf)); isc_log_write(named_g_lctx, NAMED_LOGCATEGORY_GENERAL, NAMED_LOGMODULE_SERVER, ISC_LOG_WARNING,