From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 8 Aug 2024 07:30:40 +0000 (+0200)
Subject: MINOR: mux-quic: do not trace error in qcc_send_frames() on empty list
X-Git-Tag: v3.1-dev6~55
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8939d8e4738e525d809fafff39f9c5b5051ee00c;p=thirdparty%2Fhaproxy.git

MINOR: mux-quic: do not trace error in qcc_send_frames() on empty list

qcc_send_frames() can be called with an empty list and returns
immediately with an error code. This is convenience to be able to call
it in a while loop.

Remove the trace with "error" when this is the case and replacing it
with a less alarming "leaving on..." message. This should help debugging
when traces are active.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 81cfa7a059..8755f742ac 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -1966,8 +1966,8 @@ static int qcc_send_frames(struct qcc *qcc, struct list *frms)
 	TRACE_ENTER(QMUX_EV_QCC_SEND, qcc->conn);
 
 	if (LIST_ISEMPTY(frms)) {
-		TRACE_DEVEL("no frames to send", QMUX_EV_QCC_SEND, qcc->conn);
-		goto err;
+		TRACE_DEVEL("leaving on no frame to send", QMUX_EV_QCC_SEND, qcc->conn);
+		return 1;
 	}
 
 	if (!qc_send_mux(qcc->conn->handle.qc, frms)) {