From: Alan T. DeKok <aland@freeradius.org>
Date: Sat, 11 Jan 2025 15:11:38 +0000 (-0500)
Subject: shut up coverity.  CID #1604620
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=893bca3be56246570720ffceb2bdecd2ddd6d930;p=thirdparty%2Ffreeradius-server.git

shut up coverity.  CID #1604620
---

diff --git a/src/listen/tacacs/proto_tacacs_tcp.c b/src/listen/tacacs/proto_tacacs_tcp.c
index 4493e0bfd60..bebdbaaadf9 100644
--- a/src/listen/tacacs/proto_tacacs_tcp.c
+++ b/src/listen/tacacs/proto_tacacs_tcp.c
@@ -269,6 +269,7 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim
 	 */
 	fr_assert(buffer_len >= sizeof(fr_tacacs_packet_hdr_t));
 	fr_assert(written < buffer_len);
+	fr_assert(buffer_len < (1 << 20)); /* shut up coverity */
 
 	/*
 	 *	@todo - share a stats interface with the parent?  or
@@ -286,6 +287,8 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim
 	data_size = write(thread->sockfd, buffer + written, buffer_len - written);
 	if (data_size <= 0) return data_size;
 
+	fr_assert((size_t) data_size <= buffer_len); /* shut up coverity */
+
 	/*
 	 *	If we're supposed to close the socket, then go do that.
 	 */