From: Florian Krohm <florian@eich-krohm.de>
Date: Fri, 5 Jun 2015 19:35:32 +0000 (+0000)
Subject: Fix a condition that was always true. Found by cppcheck.
X-Git-Tag: svn/VALGRIND_3_11_0^2~41
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=894d47d3547e45586270b2100a3db5bbec7c3011;p=thirdparty%2Fvalgrind.git

Fix a condition that was always true. Found by cppcheck.
See BZ #348565.


git-svn-id: svn://svn.valgrind.org/vex/trunk@3150
---

diff --git a/VEX/priv/guest_arm_toIR.c b/VEX/priv/guest_arm_toIR.c
index 7cedb7de2d..15329fed1b 100644
--- a/VEX/priv/guest_arm_toIR.c
+++ b/VEX/priv/guest_arm_toIR.c
@@ -21458,7 +21458,7 @@ DisResult disInstr_THUMB_WRK (
       UInt rT2 = INSN1(11,8);
       UInt rD  = INSN1(3,0);
       if (!isBadRegT(rD) && !isBadRegT(rT) && !isBadRegT(rT2)
-          && rN != 15 && rD != rN && rD != rT && rD != rT) {
+          && rN != 15 && rD != rN && rD != rT && rD != rT2) {
          IRTemp resSC1, resSC32, data;
          // go uncond
          mk_skip_over_T32_if_cond_is_false( condT );