From: Julio Faracco <jcfaracco@gmail.com>
Date: Thu, 19 Oct 2017 15:35:03 +0000 (-0200)
Subject: util: Missing 'removeTimeoutImpl' check variable inside virEventRegisterImpl() function.
X-Git-Tag: v3.9.0-rc1~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89622ebfad0c469bc4b374d774f9a80f00474c3c;p=thirdparty%2Flibvirt.git

util: Missing 'removeTimeoutImpl' check variable inside virEventRegisterImpl() function.

The function virEventRegisterImpl() checks the attempt to replace the
registered events. But there is a duplicate variable inside the IF statement.
The variable 'removeHandleImpl' was wrongly repeated. One of them needs to be
replaced by 'removeTimeoutImpl'.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
---

diff --git a/src/util/virevent.c b/src/util/virevent.c
index 51d8714df4..87069e35b9 100644
--- a/src/util/virevent.c
+++ b/src/util/virevent.c
@@ -241,7 +241,7 @@ void virEventRegisterImpl(virEventAddHandleFunc addHandle,
               addTimeout, updateTimeout, removeTimeout);
 
     if (addHandleImpl || updateHandleImpl || removeHandleImpl ||
-        addTimeoutImpl || updateTimeoutImpl || removeHandleImpl) {
+        addTimeoutImpl || updateTimeoutImpl || removeTimeoutImpl) {
         VIR_WARN("Ignoring attempt to replace registered event loop");
         return;
     }