From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Thu, 23 Jan 2025 20:50:45 +0000 (+0200)
Subject: lib-settings: Fix using named filters in overrides
X-Git-Tag: 2.4.1~267
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89635832250939fb60aa86aef7bea3719eb3d5b5;p=thirdparty%2Fdovecot%2Fcore.git

lib-settings: Fix using named filters in overrides

SETTINGS_EVENT_FILTER_NAME has to be either in event pointers or as strlist
type. Here it was a string type, which was just ignored.
---

diff --git a/src/lib-settings/settings.c b/src/lib-settings/settings.c
index f90b9f4e21..33c1481521 100644
--- a/src/lib-settings/settings.c
+++ b/src/lib-settings/settings.c
@@ -1553,9 +1553,9 @@ settings_override_filter_match(struct settings_apply_ctx *ctx,
 			last_filter_value = NULL;
 			str_printfa(filter_string, SETTINGS_EVENT_FILTER_NAME"=\"%s\"",
 				    wildcard_str_escape(last_filter_key));
-			event_add_str(set->filter_event,
-				      SETTINGS_EVENT_FILTER_NAME,
-				      last_filter_key);
+			event_strlist_append(set->filter_event,
+					     SETTINGS_EVENT_FILTER_NAME,
+					     last_filter_key);
 			break;
 		case SET_FILTER_ARRAY: {
 			const char *value = p + 1;