From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 7 Feb 2025 00:37:37 +0000 (+1300)
Subject: s4:libsocket: better diagnostics for no interfaces
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8969e48023eaf073eb1d4e9122afe4ac98f414a7;p=thirdparty%2Fsamba.git

s4:libsocket: better diagnostics for no interfaces

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/lib/socket/interface.c b/source4/lib/socket/interface.c
index 65543c6a294..4899ef69b9f 100644
--- a/source4/lib/socket/interface.c
+++ b/source4/lib/socket/interface.c
@@ -331,8 +331,13 @@ void load_interface_list(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, s
 		ptr++;
 	}
 
-	if (!*local_interfaces) {
-		DEBUG(0,("WARNING: no network interfaces found\n"));
+	if (*local_interfaces == NULL) {
+		const char **first_ptr = lpcfg_interfaces(lp_ctx);
+		if (first_ptr != NULL && *first_ptr != NULL) {
+			DBG_ERR("None of the interfaces listed in smb.conf "
+				"'interfaces = ...' seem to exist\n");
+		}
+		DBG_ERR("WARNING: no network interfaces found\n");
 	}
 	talloc_free(ifaces);
 }
@@ -356,7 +361,7 @@ int iface_list_count(struct interface *ifaces)
 const char *iface_list_n_ip(struct interface *ifaces, int n)
 {
 	struct interface *i;
-  
+
 	for (i=ifaces;i && n;i=i->next)
 		n--;