From: Martti Rannanjärvi <martti.rannanjarvi@open-xchange.com>
Date: Tue, 29 Mar 2022 03:50:50 +0000 (+0300)
Subject: mail-crypt: fs_crypt_load_keys() - Check list for NULL before dereference
X-Git-Tag: 2.4.0~4193
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=896ff4e5f14c062b6514d203fe6b5384bcd90ccf;p=thirdparty%2Fdovecot%2Fcore.git

mail-crypt: fs_crypt_load_keys() - Check list for NULL before dereference

NULL check was after dereference here, found by Coverity.
---

diff --git a/src/plugins/mail-crypt/fs-mail-crypt.c b/src/plugins/mail-crypt/fs-mail-crypt.c
index dc078f31ee..e1d7fea68a 100644
--- a/src/plugins/mail-crypt/fs-mail-crypt.c
+++ b/src/plugins/mail-crypt/fs-mail-crypt.c
@@ -6,7 +6,6 @@ static
 int fs_crypt_load_keys(struct crypt_fs *fs, const char **error_r)
 {
 	struct mailbox_list *list = mailbox_list_fs_get_list(&fs->fs);
-	struct mail_namespace *ns = mailbox_list_get_namespace(list);
 	const char *error;
 
 	if (fs->keys_loaded)
@@ -23,6 +22,7 @@ int fs_crypt_load_keys(struct crypt_fs *fs, const char **error_r)
 		return -1;
 	}
 
+	struct mail_namespace *ns = mailbox_list_get_namespace(list);
 	if (null_strcmp(mail_user_plugin_getenv(ns->user, "mail_crypt_save_version"), "0") == 0)
 		fs->allow_missing_keys = TRUE;
 	if (mail_crypt_global_keys_load(ns->user,