From: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Date: Thu, 18 Jun 2009 14:12:44 +0000 (+0530)
Subject: cgconfigparser: Change mkdir in cgroup_config_mount_fs to mkdir -p
X-Git-Tag: v0.34~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89874676e7a84e504e3b2829228c7c3863a6d500;p=thirdparty%2Flibcgroup.git

cgconfigparser: Change mkdir in cgroup_config_mount_fs to mkdir -p

https://bugzilla.redhat.com/show_bug.cgi?id=502687 mentioned that the directory
was not getting created when a cgconfig start was being run.

This is was because we failed the mkdir. The mkdir for directories at depth
was not succeeding.

Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---

diff --git a/src/api.c b/src/api.c
index c84675cb..4de06a35 100644
--- a/src/api.c
+++ b/src/api.c
@@ -890,7 +890,7 @@ int cgroup_attach_task(struct cgroup *cgroup)
  * cg_mkdir_p, emulate the mkdir -p command (recursively creating paths)
  * @path: path to create
  */
-static int cg_mkdir_p(const char *path)
+int cg_mkdir_p(const char *path)
 {
 	char *real_path = NULL;
 	char *wd = NULL;
diff --git a/src/config.c b/src/config.c
index a93fccee..5706e1dd 100644
--- a/src/config.c
+++ b/src/config.c
@@ -371,12 +371,9 @@ int cgroup_config_mount_fs()
 		}
 
 		if (errno == ENOENT) {
-			ret = mkdir(curr->path,
-					S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
-			if (ret < 0) {
-				last_errno = errno;
-				return ECGOTHER;
-			}
+			ret = cg_mkdir_p(curr->path);
+			if (ret)
+				return ret;
 		} else if (!S_ISDIR(buff.st_mode)) {
 			errno = ENOTDIR;
 			last_errno = errno;
diff --git a/src/libcgroup-internal.h b/src/libcgroup-internal.h
index a80ae389..705ac882 100644
--- a/src/libcgroup-internal.h
+++ b/src/libcgroup-internal.h
@@ -91,6 +91,7 @@ struct cgroup_rule_list {
 /* Internal API */
 char *cg_build_path(char *name, char *path, char *type);
 int cgroup_get_uid_gid_from_procfs(pid_t pid, uid_t *euid, gid_t *egid);
+int cg_mkdir_p(const char *path);
 
 
 /*