From: Andrea Bolognani <abologna@redhat.com>
Date: Mon, 22 Jan 2024 17:50:17 +0000 (+0100)
Subject: qemu: Add missing error handling
X-Git-Tag: v10.1.0-rc1~173
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89a8862d4277e26661e5eed86ea75afc0e8c38ce;p=thirdparty%2Flibvirt.git

qemu: Add missing error handling

qemuDomainGetSCSIControllerModel() can return -1 on failure,
but qemuDomainFindOrCreateSCSIDiskController() didn't implement
any handling for this scenario.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 31b00e05ca..137904034d 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -881,6 +881,11 @@ qemuDomainFindOrCreateSCSIDiskController(virDomainObj *vm,
     else
         cont->model = model;
 
+    if (cont->model < 0) {
+        VIR_FREE(cont);
+        return NULL;
+    }
+
     VIR_INFO("No SCSI controller present, hotplugging one model=%s",
              virDomainControllerModelSCSITypeToString(cont->model));
     if (qemuDomainAttachControllerDevice(vm, cont) < 0) {