From: Jim Jagielski <jim@apache.org>
Date: Tue, 29 Dec 2015 14:17:26 +0000 (+0000)
Subject: Don't allow bad value to be updated
X-Git-Tag: 2.5.0-alpha~2490
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=89b29c504fa04046f5507188295794ee37046ee2;p=thirdparty%2Fapache%2Fhttpd.git

Don't allow bad value to be updated


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1722137 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/mod_proxy.c b/modules/proxy/mod_proxy.c
index a4664a45174..41ebd4dc994 100644
--- a/modules/proxy/mod_proxy.c
+++ b/modules/proxy/mod_proxy.c
@@ -68,9 +68,10 @@ static const char *set_worker_param(apr_pool_t *p,
         /* Normalized load factor. Used with BalancerMember,
          * it is a number between 1 and 100.
          */
-        worker->s->lbfactor = atoi(val);
-        if (worker->s->lbfactor < 1 || worker->s->lbfactor > 100)
+        ival = atoi(val);
+        if (ival < 1 || ival > 100)
             return "LoadFactor must be a number between 1..100";
+        worker->s->lbfactor = ival;
     }
     else if (!ap_casecmpstr(key, "retry")) {
         /* If set it will give the retry timeout for the worker